Re: [PATCH 0/4] Fix scalability problem in workqueue watchdog touch caused by stop_machine
From: Michal Koutný
Date: Wed Jun 26 2024 - 08:58:37 EST
Hello Nicholas.
On Tue, Jun 25, 2024 at 09:42:43PM GMT, Nicholas Piggin <npiggin@xxxxxxxxx> wrote:
> Here are a few patches to fix a lockup caused by very slow progress due
> to a scalability problem in workqueue watchdog touch being hammered by
> thousands of CPUs in multi_cpu_stop. Patch 2 is the fix.
<del>Is this something you noticed with stop_machine alone or in some broader
context?</del> I see you mention CPU hotplug in patch 2. Was it a single
CPU or SMT offlining?
Good job tracking it down touching same cacheline.
I had a suspicion [1] back in the day that cpuhp_smt_disable() would
scale in O(nr_cpus^2) but I didn't dedicate time to verifying that. Has
something similar popped up in your examination?
Also, I think your change in patch 2 effectively reduces
wq_watchdog_thresh to 3/4 of configured value. (Not sure if default
should be scaled accordingly.)
Thanks,
Michal
[1]
cpuhp_smt_disable
mutex_lock(&cpu_add_remove_lock); // cpu_maps_update_begin()
for_each_online_cpu // <-- nr_cpus
takedown_cpu(cpu)
stop_machine_cpuslocked // cpu_hotplug_lock
active_cpus = cpumask_of(cpu)
for_each_cpu(cpu, cpu_online_mask) // <-- nr_cpus
cpu_stop_queue_work(cpu, work) // this is serial
multi_cpu_stop // this runs nr_cpus in parallel
// runs on downed cpu only
take_cpu_down
// other cpus are spinning in multi_cpu_stop() until take_cpu_down
// above is finished on downed cpu
// with interrupts disabled
do {cpu_relax} while(curstate != MULTI_STOP_EXIT)
lockup_detector_cleanup() // not a touch
mutex_unlock(&cpu_add_remove_lock);
Attachment:
signature.asc
Description: PGP signature