Re: [PATCH] dmaengine: hsu: Add check for dma_set_max_seg_size in hsu_dma_probe()

From: Markus Elfring
Date: Wed Jun 26 2024 - 11:28:09 EST

Next message: Jerome Brunet: "[PATCH 1/2] arm64: dts: amlogic: gx: correct hdmi clocks"
Previous message: syzbot: "[syzbot] [fs?] linux-next test error: BUG: sleeping function called from invalid context in mas_alloc_nodes"
In reply to: Ma Ke: "[PATCH] dmaengine: hsu: Add check for dma_set_max_seg_size in hsu_dma_probe()"
Next in thread: Christoph Hellwig: "Re: [PATCH] dmaengine: hsu: Add check for dma_set_max_seg_size in hsu_dma_probe()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> As the possible failure of the dma_set_max_seg_size(), we should better
> check the return value of the dma_set_max_seg_size().

Please avoid the repetition of a function name in such a change description.
Can it be improved with corresponding imperative wordings?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc5#n94

Regards,
Markus

Next message: Jerome Brunet: "[PATCH 1/2] arm64: dts: amlogic: gx: correct hdmi clocks"
Previous message: syzbot: "[syzbot] [fs?] linux-next test error: BUG: sleeping function called from invalid context in mas_alloc_nodes"
In reply to: Ma Ke: "[PATCH] dmaengine: hsu: Add check for dma_set_max_seg_size in hsu_dma_probe()"
Next in thread: Christoph Hellwig: "Re: [PATCH] dmaengine: hsu: Add check for dma_set_max_seg_size in hsu_dma_probe()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]