Re: [PATCH] perf unwind-libunwind: Add malloc() failure handling

From: Yunseong Kim
Date: Wed Jun 26 2024 - 11:48:04 EST


Hi Namhyung,

On 6/26/24 1:01 오후, Namhyung Kim wrote:
> On Thu, 20 Jun 2024 05:42:12 +0900, yskelg@xxxxxxxxx wrote:

>> This patch resolve following warning.
>>
>> tools/perf/util/evsel.c:1620:9: error: result of comparison of constant
>> -1 with expression of type 'char' is always false
>> -Werror,-Wtautological-constant-out-of-range-compare
>> 1620 | if (c == -1)
>> | ~ ^ ~~
>>
>> [...]

> Applied to perf-tools-next, thanks!

Thank you!

>> Add malloc() failure handling in unread_unwind_spec_debug_frame().
>> This make caller find_proc_info() works well when the allocation failure.
>>
>>
>
> Applied to perf-tools-next, thanks!
>
> Best regards,
> Namhyung


Thank you for applying my patch set.

I've been looking up the feedback you provided earlier and analyzing it
further.

Next time, I will strive to send a more meaningful patch set.


Warm regards,
Yunseong Kim