Re: [PATCH v2 4/4] EDAC/mce_amd: Add support for FRU Text in MCA

From: Borislav Petkov
Date: Wed Jun 26 2024 - 14:20:47 EST


On Wed, Jun 26, 2024 at 01:00:30PM -0500, Naik, Avadhut wrote:
> >
> > Why are you clearing it if you're overwriting it immediately?
> >
> Since its a local variable, wanted to ensure that the memory is zeroed out to prevent
> any issues with the %s specifier, used later on.

What issues?

> Would you recommend removing that and using initializer instead for the string?

I'd recommend looking at what the code does and then really thinking whether
that makes any sense.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette