Re: [PATCH 1/1] ASoC: sunxi: sun4i-i2s: fix LRCLK polarity in i2s mode

[Mark Brown]

On Fri, Jun 07, 2024 at 10:04:43AM +0200, Matteo Martelli wrote:
> Maxime Ripard wrote:
> > > -	/*
> > > -	 * DAI clock polarity
> > > -	 *
> > > -	 * The setup for LRCK contradicts the datasheet, but under a
> > > -	 * scope it's clear that the LRCK polarity is reversed
> > > -	 * compared to the expected polarity on the bus.
> > > -	 */
> > 
> > I think we should keep that comment somewhere.
> 
> I think that keeping that comment would be very misleading since the LRCLK
> setup would not contradict the datasheet anymore [1][2].
> 
> Also, do you recall any details about the mentioned scope test setup? Was i2s
> mode tested in that occasion? It would help clarify the situation.
> 
> Could anyone verify this patch against H3/H6 SoCs?

Any news on any of this?

Attachment: signature.asc
Description: PGP signature