Re: [PATCH 3/4] rust: macros: Enable use from macro_rules!

[Ethan D. Twardy]

On Mon Jun 24, 2024 at 3:43 AM CDT, Alice Ryhl wrote:
> The actual change looks good to me.
>
> Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
>

Thank you!

> Normally this would be formatted as:
>
> Link: https://doc.rust-lang.org/stable/proc_macro/enum.Delimiter.html [1]
> Signed-off-by: Ethan D. Twardy <ethan.twardy@xxxxxxxxx>

Ah, thank you for informing me on this :).

> There's a non-hidden empty line between the last constant and
> `macro_rules! pub_no_prefix`. You should either hide the empty line or
> get rid of it, because it will look weird when the example is rendered.
>
>
> Another option would be to keep the import so that the empty line
> separates the import from the macro declaration.

Done! (And the one other identical one, as well).

> I would probably indent [<$prefix $newname:span>] one more time.
>
> Alice

Done, as well. As with PATCH 2/4, these will ship with v2.