Re: [PATCH] net: phy: phy_device: Fix PHY LED blinking code comment

From: Marek Vasut
Date: Thu Jun 27 2024 - 00:29:47 EST


On 6/26/24 7:32 PM, Andrew Lunn wrote:
On Wed, Jun 26, 2024 at 05:06:17AM +0200, Marek Vasut wrote:
Fix copy-paste error in the code comment. The code refers to
LED blinking configuration, not brightness configuration. It
was likely copied from comment above this one which does
refer to brightness configuration.

Fixes: 4e901018432e ("net: phy: phy_device: Call into the PHY driver to set LED blinking")
Signed-off-by: Marek Vasut <marex@xxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

There is a lot of context in this patch. Do you have some odd git diff
settings?

I did use git format-patch -U10 this time, to make sure that context is visible. With regular git format-patch, the diff contained only part of the comment and it wasn't clear from the diff that it does modify comment above (*led_blink_set)() and not e.g. (*led_brightness_set)() .