RE: [EXT] [PATCH 26/43] wifi: nxpwifi: add sdio.c

[David Lin]

> -----Original Message-----
> From: Nemanov, Michael <michael.nemanov@xxxxxx>
> Sent: Thursday, June 27, 2024 2:27 PM
> To: David Lin <yu-hao.lin@xxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; briannorris@xxxxxxxxxxxx;
> kvalo@xxxxxxxxxx; francesco@xxxxxxxxxx; Pete Hsieh
> <tsung-hsien.hsieh@xxxxxxx>
> Subject: [EXT] [PATCH 26/43] wifi: nxpwifi: add sdio.c
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On 6/27/2024 6:37 AM, David Lin wrote:
> >>
> >> On 6/21/2024 10:51 AM, David Lin wrote:
> >> ...
> >>> +
> >>> +/* This function unregisters the SDIO device.
> >>> + *
> >>> + * The SDIO IRQ is released, the function is disabled and driver
> >>> + * data is set to null.
> >>> + */
> >>> +static void
> >>> +nxpwifi_unregister_dev(struct nxpwifi_adapter *adapter) {
> >>> +     struct sdio_mmc_card *card = adapter->card;
> >>> +
> >>> +     if (adapter->card) {
> >>> +             card->adapter = NULL;
> >>> +             sdio_claim_host(card->func);
> >>> +             sdio_disable_func(card->func);
> >>> +             sdio_release_host(card->func);
> >>> +     }
> >>> +}
> >>
> >> Missing call to sdio_release_irq() ?
> >>
> >> Michael.
> >
> > sdio_release_irq() is called by nxpwifi_sdio_disable_host_int().
> >
> > David
> 
> Right, I see you calling it from nxpwifi_uninit_sw(). Maybe just align the
> comment then.
> 
> Michael.

I will modify the comment.

Thanks,
David