Re: [PATCH 1/1] dt-bindings: usb: Convert fsl-usb to yaml

From: Krzysztof Kozlowski
Date: Thu Jun 27 2024 - 03:00:28 EST


On 26/06/2024 17:04, Frank Li wrote:
> On Wed, Jun 26, 2024 at 11:26:18AM +0200, Krzysztof Kozlowski wrote:
>> On 25/06/2024 04:25, Frank Li wrote:
>>> Convert fsl-usb binding doc to yaml format.
>>>
>>> Additional change:
>>
>>
>>> - usb@4000 {
>>> - compatible = "fsl,mpc5121-usb2-dr";
>>> - reg = <0x4000 0x1000>;
>>> - #address-cells = <1>;
>>> - #size-cells = <0>;
>>> - interrupt-parent = < &ipic >;
>>> - interrupts = <44 0x8>;
>>> - dr_mode = "otg";
>>> - phy_type = "utmi_wide";
>>> - fsl,invert-drvvbus;
>>> - fsl,invert-pwr-fault;
>>> - };
>>> diff --git a/Documentation/devicetree/bindings/usb/fsl-usb.yaml b/Documentation/devicetree/bindings/usb/fsl-usb.yaml
>>> new file mode 100644
>>> index 0000000000000..8b5724e213f09
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/usb/fsl-usb.yaml
>>
>> fsl,usb.yaml
>> or: fsl,usb2.yaml
>>
>>> +
>>> +maintainers:
>>> + - Frank Li <Frank.Li@xxxxxxx>
>>> +
>>> +description: |
>>
>> Do not need '|' unless you need to preserve formatting.
>
> dt_binding_check report error without '|'
> fsl,usb2.yaml:15:11: [error] syntax error: mapping values are not allowed here (syntax)
>
> "Practice:" impact yaml parse.

Ah, indeed.

Best regards,
Krzysztof