Re: [PATCH 2/2] interconnect: qcom: Add MSM8953 driver

[Krzysztof Kozlowski]

On 26/06/2024 22:35, Barnabás Czémán wrote:
> From: Vladimir Lypak <vladimir.lypak@xxxxxxxxx>


Thank you for your patch. There is something to discuss/improve.


> +
> +static const struct regmap_config msm8953_bimc_regmap_config = {
> +	.fast_io = true,
> +	.max_register = 0x5a000,
> +	.reg_bits = 32,
> +	.reg_stride = 4,
> +	.val_bits = 32,
> +};
> +
> +static const struct qcom_icc_desc msm8953_bimc = {
> +	.type = QCOM_ICC_BIMC,
> +	.bus_clk_desc = &bimc_clk,
> +	.nodes = msm8953_bimc_nodes,
> +	.num_nodes = ARRAY_SIZE(msm8953_bimc_nodes),
> +	.qos_offset = 0x8000,
> +	.regmap_cfg = &msm8953_bimc_regmap_config
> +};
> +
> +static struct qcom_icc_node *msm8953_pcnoc_nodes[] = {

This should be '* const '


Best regards,
Krzysztof