Re: Aw: [PATCH v3 1/2] arm64: dts: mt7986: add dtbs with applied overlays for bpi-r3

[AngeloGioacchino Del Regno]

Il 26/06/24 22:45, Frank Wunderlich ha scritto:
> any suggestions? hoping it does no laying around so long as v2

So you're trying to just test that the overlay is valid and can actually be
overlaid to the base dts?

I'm not sure that this is the right/best way... and I honestly have no time
to check that *exactly right now*, even though that should be.

I have to be convinced of what I'm doing before applying patches, and I know
that this was sent a bit of time ago, but I really didn't have any time to
dig into that... let's see if for some miracle I can do that for this cycle
otherwise it's going to be the next one.

I mean no disrespect to Rob who suggested this change, but I still want to
check that on my own before picking it.

Sorry about the delays

Cheers,
Angelo


> regards Frank
>
>
> > Gesendet: Samstag, 08. Juni 2024 um 10:05 Uhr
> > Von: "Frank Wunderlich" <linux@xxxxxxxxx>
> > An: "Matthias Brugger" <matthias.bgg@xxxxxxxxx>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@xxxxxxxxxxxxx>, "Rob Herring" <robh@xxxxxxxxxx>, "Krzysztof Kozlowski" <krzk+dt@xxxxxxxxxx>, "Conor Dooley" <conor+dt@xxxxxxxxxx>
> > Cc: "Frank Wunderlich" <frank-w@xxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-mediatek@xxxxxxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, "Daniel Golle" <daniel@xxxxxxxxxxxxxx>, "Rob Herring" <robh+dt@xxxxxxxxxx>
> > Betreff: [PATCH v3 1/2] arm64: dts: mt7986: add dtbs with applied overlays for bpi-r3
> >
> > From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> >
> > Build devicetree binaries for testing overlays and providing users
> > full dtb without using overlays.
> >
> > Suggested-by: Rob Herring <robh+dt@xxxxxxxxxx>
> > Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> > ---
> > https://lore.kernel.org/all/CAL_JsqK_3xxD0DFwipXO85P=q=EYjUdjE1_8g1MKtvw3vVzx5A@xxxxxxxxxxxxxx/
> > https://lore.kernel.org/all/CAL_JsqJSi=kJSix=f3787ULZnaCy_Y26Phdhy5y9fat_vkDuUw@xxxxxxxxxxxxxx/
> >
> > v2:
> > make full dtbs multiline for better readability
> > ---
> >   arch/arm64/boot/dts/mediatek/Makefile | 21 +++++++++++++++++++++
> >   1 file changed, 21 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
> > index 37b4ca3a87c9..0ec5b904d35d 100644
> > --- a/arch/arm64/boot/dts/mediatek/Makefile
> > +++ b/arch/arm64/boot/dts/mediatek/Makefile
> > @@ -15,6 +15,27 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtbo
> >   dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo
> >   dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nor.dtbo
> >   dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd.dtbo
> > +mt7986a-bananapi-bpi-r3-emmc-nand-dtbs := \
> > +	mt7986a-bananapi-bpi-r3.dtb \
> > +	mt7986a-bananapi-bpi-r3-emmc.dtbo \
> > +	mt7986a-bananapi-bpi-r3-nand.dtbo
> > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nand.dtb
> > +mt7986a-bananapi-bpi-r3-emmc-nor-dtbs := \
> > +	mt7986a-bananapi-bpi-r3.dtb \
> > +	mt7986a-bananapi-bpi-r3-emmc.dtbo \
> > +	mt7986a-bananapi-bpi-r3-nor.dtbo
> > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc-nor.dtb
> > +mt7986a-bananapi-bpi-r3-sd-nand-dtbs := \
> > +	mt7986a-bananapi-bpi-r3.dtb \
> > +	mt7986a-bananapi-bpi-r3-sd.dtbo \
> > +	mt7986a-bananapi-bpi-r3-nand.dtbo
> > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nand.dtb
> > +mt7986a-bananapi-bpi-r3-sd-nor-dtbs := \
> > +	mt7986a-bananapi-bpi-r3.dtb \
> > +	mt7986a-bananapi-bpi-r3-sd.dtbo \
> > +	mt7986a-bananapi-bpi-r3-nor.dtbo
> > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-sd-nor.dtb
> > +
> >   dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-rfb.dtb
> >   dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986b-rfb.dtb
> >   dtb-$(CONFIG_ARCH_MEDIATEK) += mt7988a-bananapi-bpi-r4.dtb
> > --
> > 2.34.1