Re: [PATCH] riscv: entry: always initialize regs->a0 to -ENOSYS
From: Celeste Liu
Date: Thu Jun 27 2024 - 10:29:15 EST
On 2024-06-27 22:08, Björn Töpel wrote:
> Celeste Liu <coelacanthushex@xxxxxxxxx> writes:
>
>> Otherwise when the tracer changes syscall number to -1, the kernel fails
>> to initialize a0 with -ENOSYS and subsequently fails to return the error
>> code of the failed syscall to userspace. For example, it will break
>> strace syscall tampering.
>>
>> Fixes: 52449c17bdd1 ("riscv: entry: set a0 = -ENOSYS only when syscall != -1")
>> Cc: stable@xxxxxxxxxxxxxxx
>> Signed-off-by: Celeste Liu <CoelacanthusHex@xxxxxxxxx>
>
> Reported-by: "Dmitry V. Levin" <ldv@xxxxxxxxx>
> Reviewed-by: Björn Töpel <bjorn@xxxxxxxxxxxx>
Patch v2 has been sent.