Re: [PATCH v3 0/2] ext4: fix fast commit inode enqueueing during a full journal commit

[Luis Henriques]

On Thu, Jun 27 2024, Theodore Ts'o wrote:

> On Thu, Jun 27, 2024 at 02:54:39PM +0100, Luis Henriques wrote:
>> On Wed, May 29 2024, Luis Henriques (SUSE) wrote:
>> 
>> > Hi!
>> >
>> > Here's v3 of this fix to the fast commit enqueuing bug triggered by fstest
>> > generic/047.  This version simplifies the previous patch version by re-using
>> > the i_sync_tid field in struct ext4_inode_info instead of adding a new one.
>> >
>> > The extra patch includes a few extra fixes to the tid_t type handling.  Jan
>> > brought to my attention the fact that this sequence number may wrap, and I
>> > quickly found a few places in the code where the tid_geq() and tid_gt()
>> > helpers had to be used.
>> >
>> > Again, please note that this fix requires [1] to be applied too.
>> >
>> > [1] https://lore.kernel.org/all/20240515082857.32730-1-luis.henriques@xxxxxxxxx
>> >
>> > Luis Henriques (SUSE) (2):
>> >   ext4: fix fast commit inode enqueueing during a full journal commit
>> >   ext4: fix possible tid_t sequence overflows
>> 
>> Gentle ping...  Has this fell through the cracks?
>
> Sorry, I'm still catching up after being on vacation.  There is a
> batch of commits which I've reviewed (up to May 17th) which is
> currently undergoing testing.  So that doesn't include this patch yet,
> but it's on the list of patches to be reviewed at
> patchworks.ozlabs.org/project/linux-ext4 so it won't fall through the
> cracks.

Awesome, thanks for the update.  And sorry for being impatient.
/me goes back under his rock.

Cheers,
-- 
Luís