Re: [PATCH v2 net-next 3/3] net: phy: aquantia: add support for aqr115c

From: Andrew Lunn
Date: Thu Jun 27 2024 - 12:23:15 EST


On Thu, Jun 27, 2024 at 01:30:17PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> Add support for a new model to the Aquantia driver. This PHY supports
> Overlocked SGMII mode with 2.5G speeds.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> ---
> drivers/net/phy/aquantia/aquantia_main.c | 39 +++++++++++++++++++++++-
> 1 file changed, 38 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/aquantia/aquantia_main.c b/drivers/net/phy/aquantia/aquantia_main.c
> index 974795bd0860..98ccefd355d5 100644
> --- a/drivers/net/phy/aquantia/aquantia_main.c
> +++ b/drivers/net/phy/aquantia/aquantia_main.c
> @@ -29,6 +29,7 @@
> #define PHY_ID_AQR113 0x31c31c40
> #define PHY_ID_AQR113C 0x31c31c12
> #define PHY_ID_AQR114C 0x31c31c22
> +#define PHY_ID_AQR115C 0x31c31c33
> #define PHY_ID_AQR813 0x31c31cb2
>
> #define MDIO_PHYXS_VEND_IF_STATUS 0xe812
> @@ -111,7 +112,6 @@ static u64 aqr107_get_stat(struct phy_device *phydev, int index)
> int len_h = stat->size - len_l;
> u64 ret;
> int val;
> -
> val = phy_read_mmd(phydev, MDIO_MMD_C22EXT, stat->reg);
> if (val < 0)
> return U64_MAX;

White space change. And that blank line is actually wanted to separate
the variables from the code.

Andrew

---
pw-bot: cr