Re: [PATCH] vfs: rename parent_ino to d_parent_ino and make it use RCU

From: Christian Brauner
Date: Thu Jun 27 2024 - 12:31:01 EST


On Thu, Jun 27, 2024 at 06:11:52PM GMT, Mateusz Guzik wrote:
> The routine is used by procfs through dir_emit_dots.
>
> The combined RCU and lock fallback implementation is too big for an
> inline. Given that the routine takes a dentry argument fs/dcache.c seems
> like the place to put it in.
>
> Signed-off-by: Mateusz Guzik <mjguzik@xxxxxxxxx>
> ---
>
> this shows up with stress-ng --getdent (as one of many things)
>
> build-tested with first adding d_parent_ino, then building allmodconfig
> and fixing failures as they pop up. by the end of it grep shows no
> remaining occurences, so i don't believe there will be any build regressions.
>
> scheme borrowed from dget_parent

I like it.