Re: [PATCH v2 07/13] arm64: dts: layerscaple: add #dma-cells for qdma

From: Rob Herring
Date: Thu Jun 27 2024 - 13:25:21 EST


On Thu, Jun 27, 2024 at 11:17 AM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> On Wed, Jun 26, 2024 at 2:26 PM Frank Li <Frank.Li@xxxxxxx> wrote:
> >
> > Add #dma-cells for qdma to fix below warning.
> > dma-controller@8380000: '#dma-cells' is a required property
> >
> > Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 1 +
> > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 1 +
> > arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
> > 3 files changed, 3 insertions(+)
>
> Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>

Except for the typo in the subject...

Frank, while I appreciate the great number of reductions in DT
warnings on FSL platforms you and others have been working on, your
work is sloppy with issues you should find yourself.

Rob