Re: [PATCH V3] cgroup/cpuset: Prevent UAF in proc_cpuset_show()

[Waiman Long]

On 6/27/24 14:29, Tejun Heo wrote:
> Hello,
>
> On Thu, Jun 27, 2024 at 11:46:10AM +0200, Michal Koutný wrote:
> > Your patch should work thanks to the rcu_read_lock and
> > cgroup_free_root/kfree_rcu and the `if (css->cgroup)` guard is
> > unnecessary.

I also notice that the if (css->cgroup) guard is not needed. I didn't 
reject it because it doesn't hurt.

Cheers,
Longman

> > So the patch is a functional fix, the reasoning in commit message is
> > little off. Not sure if Tejun rebases his for-6.10-fixes (with a
> > possible v4), full fixup commit for this may not be worthy.
> This one's on the top. If Chen can send me a patch with updated description,
> I will replace the patch.
>
> Thanks.