Re: [PATCH net-next v3] enic: add ethtool get_channel support

[Jon Kohler]

> On Jun 26, 2024, at 10:10 PM, Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
> 
> On Tue, 25 Jun 2024 17:53:38 -0700 Jon Kohler wrote:
>> + channels->combined_count = 1;
> 
> clang complains about the lack of break or fallthrough here,
> as annoying and pointless of a warning as it is :(

Ah, right - fixed in v4 just now

> 
> drivers/net/ethernet/cisco/enic/enic_ethtool.c:627:2: note: insert 'break;' to avoid fall-through
>  627 |         default:
>      |         ^
>      |         break; 
> 
>> + default:
>> + break;
> -- 
> pw-bot: cr