Re: [PATCH net-next v2] net: core: Remove the dup_errno parameter in dev_prep_valid_name()

[Jakub Kicinski]

On Thu, 27 Jun 2024 21:41:31 +0800 Yajun Deng wrote:
> netdev_name_in_use() in dev_prep_valid_name() return -EEXIST makes
> more sense if it's not NULL, but dev_alloc_name() should keep the
> -ENFILE errno.
> 
> There are three callers to dev_prep_valid_name(), the dup_errno
> parameter is only for dev_alloc_name, it's not necessary for the other
> callers.
> 
> Remove the dup_errno parameter in dev_prep_valid_name() and add a
> conditional operator to dev_alloc_name(), replace -EEXIST with
> -ENFILE.

Let me be more direct this time - I like this code the way I wrote it.
Please leave it be.
-- 
pw-bot: reject