Re: [PATCH net-next v1 3/3] net: dsa: microchip: lan937x: disable VPHY output

From: Vladimir Oltean
Date: Thu Jun 27 2024 - 18:38:32 EST


On Thu, Jun 27, 2024 at 02:39:11PM +0200, Oleksij Rempel wrote:
> The VPHY is a compatibility functionality to be able to attach network
> drivers without fixed-link support to the switch, which generally
> should not be needed with linux network drivers.

Sorry, I don't have much to base my judgement upon. I did search for the
"VPHY" string and found it to be accessed in the dev_ops->r_phy() and
dev_ops->w_phy() implementations, suggesting that it is more than just
that? These methods are used for accessing the registers of the embedded
PHYs for user ports. I don't see what is the connection with RGMII on
the CPU port.