Re: [PATCH v2 1/6] x86/irq: Add enumeration of NMI source reporting CPU feature

From: Jacob Pan
Date: Fri Jun 28 2024 - 00:55:38 EST



On Fri, 21 Jun 2024 16:00:47 -0700, Sohil Mehta <sohil.mehta@xxxxxxxxx>
wrote:

> >> +config X86_NMI_SOURCE
> >
> > Lets reuse X86_FRED instead of adding another hard config option. See
> > below.
> >
>
> I mostly agree with the suggestion here but there seems to be a bit of
> confusion regarding feature availability and feature activation.
>
> Availability and activation of X86_FEATURE_NMI_SOURCE depends on FRED
> but not the other way around.
>
> In other words, CONFIG_X86_NMI_SOURCE would only be useful if someone
> wants to disable NMI_SOURCE even if both X86_FEATURE_FRED and
> X86_FEATURE_NMI_SOURCE are available on a platform.
>
> This seems unlikely to me. Reusing CONFIG_X86_FRED seems reasonable.
agreed, will remove CONFIG_X86_NMI_SOURCE


Thanks,

Jacob