Re: [PATCH] s390/ism: Add check for dma_set_max_seg_size in ism_probe()

From: Christoph Hellwig
Date: Fri Jun 28 2024 - 01:51:10 EST


On Wed, Jun 26, 2024 at 02:48:30PM +0200, Gerd Bayer wrote:
>
> However, since ISM devices are PCI attached (and will remain PCI
> attached I believe) we can take the existance of dev->dma_parms for
> granted since pci_device_add() (in drivers/pci/probe.c) will make that
> point to the pci_dev's dma_parms for every PCI device.
>
> So I'm not sure how important this fix is.

It's not just important, it is stupid and I told them to stop sending
these kinds of crap patches.