Re: [PATCH] mm/gup: Use try_grab_page() instead of try_grab_folio() in gup slow path

From: Ge Yang
Date: Fri Jun 28 2024 - 02:53:50 EST




在 2024/6/28 14:11, Christoph Hellwig 写道:
I was complaining that switching from a folio to a page interface
is a retro-step. But try_grab_page and try_grab_folio actually
both take a strut page argument and do similar but different things.

Yikes!

-int __must_check try_grab_page(struct page *page, unsigned int flags)
+int __must_check try_grab_page(struct page *page, int refs, unsigned int flags)

This would now make it a try_grab_pages. Also please try to avoid
the overly lone lines here and in the external declaration.

Ok, thanks.