Re: [PATCH v2 2/2] mmc: sdhci-of-ma35d1: Add Nuvoton MA35D1 SDHCI driver

From: Shan-Chun Hung
Date: Fri Jun 28 2024 - 03:18:11 EST


Dear Adrian,

Yes, that is correct. It relates to the AHB bus DMA burst size.

    /*
     * Split data into chunks of 16 or 8 bytes for sending.
     * Each chunk transfer is guaranteed to be uninterrupted on the bus.
     * This likely corresponds to the AHB bus DMA burst size.
     */

Best Regards,

Shan-Chun

On 2024/6/28 下午 02:59, Adrian Hunter wrote:
On 28/06/24 09:30, Shan-Chun Hung wrote:
On 2024/6/27 下午 05:40, Adrian Hunter wrote:
On 26/06/24 12:49, Shan-Chun Hung wrote:
+    /* Enable INCR16 and INCR8 */
Comment would be more useful if it said what INCR16 and
INCR8 are
I will modify as follows:

/*
 * Split data into chunks of 16 or 8 bytes for sending.
 * Each chunk transfer is guaranteed to be uninterrupted on the bus.
 */

AFAICT, it relates to AHB bus DMA burst size, so maybe add
that if it is correct.