[PATCH v1 2/2] dmaengine: fsl-edma: add edma src ID check at request channel

[Joy Zou]

> -----Original Message-----
> From: Vinod Koul <vkoul@xxxxxxxxxx>
> Sent: 2024年6月28日 15:32
> To: Joy Zou <joy.zou@xxxxxxx>
> Cc: Frank Li <frank.li@xxxxxxx>; imx@xxxxxxxxxxxxxxx;
> dmaengine@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [EXT] Re: [PATCH v1 2/2] dmaengine: fsl-edma: add edma src ID
> check at request channel
 
> On 21-06-24, 18:49, Joy Zou wrote:
> > Check src ID to detect misuse of same src ID for multiple DMA channels.
> >
> > Signed-off-by: Joy Zou <joy.zou@xxxxxxx>
> > ---
> >  drivers/dma/fsl-edma-main.c | 22 ++++++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> >
> > diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
> > index d4f29ece69f5..47939d010e59 100644
> > --- a/drivers/dma/fsl-edma-main.c
> > +++ b/drivers/dma/fsl-edma-main.c
> > @@ -100,6 +100,22 @@ static irqreturn_t fsl_edma_irq_handler(int irq,
> void *dev_id)
> >       return fsl_edma_err_handler(irq, dev_id);  }
> >
> > +static bool fsl_edma_srcid_in_use(struct fsl_edma_engine *fsl_edma,
> > +u32 srcid) {
> > +     struct fsl_edma_chan *fsl_chan;
> > +     int i;
> > +
> > +     for (i = 0; i < fsl_edma->n_chans; i++) {
> > +             fsl_chan = &fsl_edma->chans[i];
> > +
> > +             if (fsl_chan->srcid && srcid == fsl_chan->srcid) {
> > +                     dev_err(&fsl_chan->pdev->dev, "The srcid is
> > + using! Can't use repeatly.");
> 
> Better message would be: "The srcid is in use, cant use!"
> 
> wdyt?
Thanks your for comments!
It's better. Will change it.
BR
Joy Zou