Re: [PATCH resubmit] rtc: ds1307: Detect oscillator fail on mcp794xx

From: Csókás Bence
Date: Fri Jun 28 2024 - 04:58:45 EST


Hi!

On 6/28/24 00:37, Alexandre Belloni wrote:
Hello,

It is not clear to me why your resent this one but not the other one,
can you elaborate?

It was kind of an unrelated patch, I'll send it after I get this one merged. But so far, there hasn't been any movements on this series at all.

On 21/06/2024 10:05:13+0200, Csókás, Bence wrote:
This patch enables the detection of the oscillator failure
on mcp794xx chips.

Co-developed-by: Szentendrei, Tamás <szentendrei.tamas@xxxxxxxxx>
Signed-off-by: Szentendrei, Tamás <szentendrei.tamas@xxxxxxxxx>
Signed-off-by: Csókás, Bence <csokas.bence@xxxxxxxxx>

The "other one", I assume, refers to this:

On 6/11/24 09:24, Csókás, Bence wrote:
> `tm_year` may go up to 299 if the device supports the
> century bit. Therefore, subtracting may not give us
> a valid 2-digit number, but modulo does.
>
> Co-developed-by: Szentendrei, Tamás <szentendrei.tamas@xxxxxxxxx>
> Signed-off-by: Szentendrei, Tamás <szentendrei.tamas@xxxxxxxxx>
> Signed-off-by: Csókás, Bence <csokas.bence@xxxxxxxxx>

And the only thing they had in common is that they were in the same file, which my colleague, Tamás, put into one commit in our tree, that I split for upstreaming purposes. But really, they are not really related or interdependent on one another.

Bence