Re: [PATCH v4 2/4] block: partitions: populate fwnode
From: Daniel Golle
Date: Fri Jun 28 2024 - 08:17:14 EST
Hi Christoph,
thank you for reviewing.
On Thu, Jun 27, 2024 at 09:44:28PM -0700, Christoph Hellwig wrote:
> On Thu, Jun 27, 2024 at 09:50:39PM +0100, Daniel Golle wrote:
> > + /*
> > + * In case 'uuid' is defined in the partitions firmware node require
> > + * partition meta info being present and the specified uuid to match.
> > + */
>
> Overly long lines, which is really annyoing for block comments.
Should I use 80 chars as limit everywhere?
>
> > + got_uuid = !fwnode_property_read_string(fw_part, "uuid", &uuid);
> > + if (got_uuid && (!bdev->bd_meta_info ||
> > + !part_meta_match(uuid, bdev->bd_meta_info->uuid,
> > + PARTITION_META_INFO_UUIDLTH)))
>
> Can we please not use the crazy part_meta stuff for anything new?
> We should never have merge it, and right now it is at least isolated
> to the boot time root dev_t partsing, and I'd really prefer to keep it
> in that corner.
>
At least up to my understanding there isn't any other to know a
partitions UUID or volume name.
If there is another way to access this information I'd happily make
use of it, but I couldn't find any.