Re: [PATCH v2 net-next 3/3] net: phy: aquantia: add support for aqr115c
From: Andrew Lunn
Date: Fri Jun 28 2024 - 10:09:39 EST
> Not sure what to do, should I still be adding a new mode here or is it
> fine to just explain in the commit message that this really is
> "2500Base-X-sans-in-band-signalling" and keep the code as is? Or maybe
> some quirk disallowing `managed = "in-band-status"`?
Yes, please do make it clear in the commit message. It is good to have
a full commit message explaining all the messy details to help the
next person who needs to modify this code, or has the same issue with
another vendor specific glue driver for stmmac, etc.
Andrew