Re: [PATCH v4 0/9] Add Mule MFD support

From: Guenter Roeck
Date: Fri Jun 28 2024 - 11:05:34 EST


On 6/28/24 02:03, Farouk Bouabid wrote:
Hi Guenter,

On 28.06.24 02:05, Guenter Roeck wrote:
On 6/24/24 09:13, Farouk Bouabid wrote:
Hi Guenter,

On 19.06.24 15:31, Guenter Roeck wrote:
On 6/19/24 00:45, Farouk Bouabid wrote:


[...]



If we cannot proceed with that then we could add a compatible to the amc6821 driver to add the mux device (Basically the "tsd,mule" compatible in amc6821 compatible list would be a combo driver with mux logic + amc6821). Do you think that is more appropriate ?


Implement the mux as part of the amc6821 driver ? No. We could discuss
instantiating the i2c mux driver from the amc6821 driver.


If I understand correctly we would have the amc6821 for "tsd,mule" compatible probe the mule-i2c-mux as platform_device. Possible DT representation would be something like:


Yes, something like that. I have a patch series ready which converts the amc6821
to use regmap, so the i2c-mux driver might work as-is with that patch series in place.

Thanks,
Guenter