Re: [PATCH v3 20/38] x86/resctrl: Change mon_event_config_{read,write}() to be arch helpers

[Reinette Chatre]

Hi James,

On 6/14/24 8:00 AM, James Morse wrote:

...

> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
> index fbae9a907544..65f0a2d17e4b 100644
> --- a/include/linux/resctrl.h
> +++ b/include/linux/resctrl.h
> @@ -220,6 +220,13 @@ struct resctrl_cpu_defaults {
>   	u32 rmid;
>   };
>   
> +struct resctrl_mon_config_info {
> +	struct rdt_resource	*r;
> +	struct rdt_domain	*d;
> +	u32			evtid;
> +	u32			mon_config;
> +};
> +
>   /**
>    * resctrl_arch_sync_cpu_closid_rmid() - Refresh this CPU's CLOSID and RMID.
>    *					 Call via IPI.
> @@ -263,6 +270,8 @@ struct rdt_domain *resctrl_arch_find_domain(struct rdt_resource *r, int id);
>   int resctrl_arch_update_domains(struct rdt_resource *r, u32 closid);
>   
>   bool resctrl_arch_is_evt_configurable(enum resctrl_event_id evt);
> +void resctrl_arch_mon_event_config_write(void *info);
> +void resctrl_arch_mon_event_config_read(void *info);
>  

Considering this is the API doc I think it will be useful to have a comment that
connects the void pointers in these functions to struct resctrl_mon_config_info.
 
>   /*
>    * Update the ctrl_val and apply this config right now.

Reinette