Re: [PATCH net-next v6 05/10] net: openvswitch: add psample action

[Eelco Chaudron]

On 28 Jun 2024, at 13:05, Adrian Moreno wrote:

> Add support for a new action: psample.
>
> This action accepts a u32 group id and a variable-length cookie and uses
> the psample multicast group to make the packet available for
> observability.
>
> The maximum length of the user-defined cookie is set to 16, same as
> tc_cookie, to discourage using cookies that will not be offloadable.
>
> Signed-off-by: Adrian Moreno <amorenoz@xxxxxxxxxx>

I think this patch looks good. After some offline discussion on alignment with the userspace model, we decided to proceed with a psample() specific action.

With that in mind, and considering the additional changes, this patch looks good to me.

Acked-by: Eelco Chaudron echaudro@xxxxxxxxxx

Cheers,

Eelco