Re: [PATCH 2/4] cpupower: Add 'help' target to the 'debug/kernel' subproject makefile

[Shuah Khan]

On 6/23/24 13:19, Roman Storozhenko wrote:
> Add 'help' target, describing all user-available targets, to the
> 'debug/kernel' subproject makefile.
>
> Signed-off-by: Roman Storozhenko <romeusmeister@xxxxxxxxx>
> ---
>   tools/power/cpupower/debug/kernel/Makefile | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/tools/power/cpupower/debug/kernel/Makefile b/tools/power/cpupower/debug/kernel/Makefile
> index 7b5c43684be1..9e4522a42c6b 100644
> --- a/tools/power/cpupower/debug/kernel/Makefile
> +++ b/tools/power/cpupower/debug/kernel/Makefile
> @@ -21,3 +21,15 @@ install: default
>   	/sbin/depmod -a
>   
>   all:	default
> +
> +help:
> +	@echo  'Build targets:'
> +	@echo  '  all		  - Default target. Could be omitted. Builds "cpufreq-test_tsc"'
> +	@echo  '                    kernel module against the running kernel if the "CONFIG_X86_TSC"'
> +	@echo  '                    kernel config parameter is enabled. Puts the built module'
> +	@echo  '                    to the current dir'
> +	@echo  '  install	  - Install previously built "cpufreq-test_tsc.ko" module'
> +	@echo  '                    to the running kernel "modules" dir'
> +	@echo  ''
> +	@echo  'Clean targets:'
> +	@echo  '  clean		  - Clean "cpufreq-test_tsc" module build artifacts'

I don't see a value in adding this - these are common targets and
nothing new about them.

thanks,
-- Shuah