Re: [PATCH v2] platform/goldfish: goldfish_pipe: add missing MODULE_DESCRIPTION() macro
From: Jeff Johnson
Date: Fri Jun 28 2024 - 23:10:31 EST
On 6/15/2024 2:34 PM, Jeff Johnson wrote:
> With arch=x86, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/goldfish/goldfish_pipe.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
> ---
> Changes in v2:
> - Rebased to v6.10-rc3
> - Updated commit text to use a more recent boilerplate
> - Since there are no matching entries in MAINTAINERS, added Andrew & Greg
> to see if this can go through one of their misc trees
> - Link to v1: https://lore.kernel.org/r/20240509-goldfish_pipe-md-v1-1-acb513276263@xxxxxxxxxxx
> ---
> drivers/platform/goldfish/goldfish_pipe.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
> index 061aa9647c19..c2aab0cfab33 100644
> --- a/drivers/platform/goldfish/goldfish_pipe.c
> +++ b/drivers/platform/goldfish/goldfish_pipe.c
> @@ -946,4 +946,5 @@ static struct platform_driver goldfish_pipe_driver = {
>
> module_platform_driver(goldfish_pipe_driver);
> MODULE_AUTHOR("David Turner <digit@xxxxxxxxxx>");
> +MODULE_DESCRIPTION("Goldfish virtual device for QEMU pipes");
> MODULE_LICENSE("GPL v2");
>
> ---
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> change-id: 20240509-goldfish_pipe-md-1dec20bd3a90
Following up to see if anything else is needed from me. Hoping to see this in
linux-next so I can remove it from my tracking spreadsheet :)
/jeff