Re: [PATCH v3 11/11] KVM: X86: Use common code for PV IPIs in linux guest

[Xin Li]

On 6/28/2024 1:18 PM, Jacob Pan wrote:
> Paravirtual apic hooks to enable PV IPIs for KVM if the "send IPI"

s/Paravirtual apic/Paravirtualize APIC/

> hypercall is available. Reuse common code for ICR preparation which
> covers NMI-source reporting if in effect.

I see a lot of "NMI source". Should we use "NMI-source" in all places?

> Originally-by: Zeng Guang <guang.zeng@xxxxxxxxx>
> Signed-off-by: Jacob Pan <jacob.jun.pan@xxxxxxxxxxxxxxx>
> ---
>   arch/x86/kernel/kvm.c | 10 +---------
>   1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
> index 263f8aed4e2c..a45d60aa0302 100644
> --- a/arch/x86/kernel/kvm.c
> +++ b/arch/x86/kernel/kvm.c
> @@ -516,15 +516,7 @@ static void __send_ipi_mask(const struct cpumask *mask, int vector)
>   
>   	local_irq_save(flags);
>   
> -	switch (vector) {
> -	default:
> -		icr = APIC_DM_FIXED | vector;
> -		break;
> -	case NMI_VECTOR:
> -		icr = APIC_DM_NMI;
> -		break;
> -	}
> -
> +	icr = __prepare_ICR(0, vector, 0);
>   	for_each_cpu(cpu, mask) {
>   		apic_id = per_cpu(x86_cpu_to_apicid, cpu);
>   		if (!ipi_bitmap) {