Re: [PATCH v2 2/2] media: i2c: Add driver for Sony IMX728

From: Markus Elfring
Date: Sun Jun 30 2024 - 02:17:03 EST



> +++ b/drivers/media/i2c/imx728.c
> @@ -0,0 +1,4660 @@

> +static int imx728_set_fmt(struct v4l2_subdev *sd,
> + struct v4l2_subdev_state *state,
> + struct v4l2_subdev_format *fmt)
> +{

> + mutex_lock(&imx728->lock);
> +
> + fmt->format.field = V4L2_FIELD_NONE;

> + *format = fmt->format;
> +
> +done:
> + mutex_unlock(&imx728->lock);
> +
> + return ret;
> +}


Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&imx728->lock);”?
https://elixir.bootlin.com/linux/v6.10-rc5/source/include/linux/mutex.h#L196

Regards,
Markus