On 24.06.2024 1:21 PM, Naina Mehta wrote:
On 6/18/2024 7:08 PM, Konrad Dybcio wrote:
On 6/18/24 15:13, Naina Mehta wrote:
Rename qdss@88800000 memory region as qlink_logging memory region
and add qdss_mem memory region at address of 0x88500000.
Split mpss_dsmharq_mem region into 2 separate regions and
reduce the size of mpssadsp_mem region.
Signed-off-by: Naina Mehta <quic_nainmeht@xxxxxxxxxxx>
---
Alright, we're getting somewhere. The commit message should however motivate
why such changes are necessary. For all we know, the splitting in two is
currently done for no reason, as qdss_mem and qlink_logging_mem are contiguous
- does the firmware have some expectations about them being separate?
Since different DSM region size is required for different modem firmware, mpss_dsmharq_mem region being split into 2 separate regions.
This would provide the flexibility to remove the region which is
not required for a particular platform.
qlink_logging is being added at the memory region at the address of
0x88800000 as the region is being used by modem firmware.
Ok, now put that in the commit message :)
And I suppose:
"This would provide the flexibility to remove the region which is not
required for a particular platform." - but you still pass both to the
remoteproc in patch 4. Are these regions mutually exclusive?
Konrad