Re: [PATCH v1] ASoc: tas2781: Add name_prefix as the prefix name of DSP firmwares and calibrated data files

From: Mark Brown
Date: Mon Jul 01 2024 - 08:23:43 EST


On Sat, Jun 29, 2024 at 06:11:10PM +0800, Shenghao Ding wrote:

> tas_priv->fw_state = TASDEVICE_RCA_FW_OK;
> - scnprintf(tas_priv->coef_binaryname, 64, "%s_coef.bin",
> - tas_priv->dev_name);
> + if (tas_priv->name_prefix)
> + scnprintf(tas_priv->rca_binaryname, 64, "%s-%s_coef.bin",
> + tas_priv->name_prefix, tas_priv->dev_name);
> + else
> + scnprintf(tas_priv->coef_binaryname, 64, "%s_coef.bin",
> + tas_priv->dev_name);

I'll apply this but I do wonder if it's worth falling back to trying to
load the unprefixed name if we fail to load the prefixed one.

Attachment: signature.asc
Description: PGP signature