Re: [PATCH v10 07/24] virt: sev-guest: Store VMPCK index to SNP guest device structure

[Borislav Petkov]

On Mon, Jul 01, 2024 at 04:15:31PM +0530, Nikunj A. Dadhania wrote:
> In my v8 [1] and earlier series, I had dropped secrets pages pointer from
> snp_guest_dev structure. But with newer changes in v9 secrets pages pointer
> is retained so all these APIs will still be fine. 

So I think you should step back, get a pen and paper and think about the
design of what is going to be exported from sev.c to sev-guest, write it down
and run it by folks first before you go code.

Because right now it feels like a waste of time for everybody involved.
I still have no clue what is going on - just a rough idea.

Also, looking forward:

Subject: [PATCH v10 13/24] x86/sev: Make sev-guest driver functional again

That's a no-no.

You can't have a broken kernel at some point in the patch series. Unless you
can't really avoid it. And I don't think there's a problem here: you define
the interfaces and switch sev-guest to them in one last patch.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette