Re: [PATCH 2/5] vdso: Add comment about reason for vdso struct ordering

[Vincenzo Frascino]

On 01/07/2024 15:47, Anna-Maria Behnsen wrote:
> Signed-off-by: Anna-Maria Behnsen <anna-maria@xxxxxxxxxxxxx>

nit: Can you please add something in the commit message?

Otherwise:

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>

> ---
>  include/vdso/datapage.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/vdso/datapage.h b/include/vdso/datapage.h
> index d04d394db064..7647e0946f50 100644
> --- a/include/vdso/datapage.h
> +++ b/include/vdso/datapage.h
> @@ -77,6 +77,10 @@ struct vdso_timestamp {
>   * vdso_data will be accessed by 64 bit and compat code at the same time
>   * so we should be careful before modifying this structure.
>   *
> + * The ordering of the struct members is optimized to have fast access to the
> + * often required struct members which are related to CLOCK_REALTIME and
> + * CLOCK_MONOTONIC. This information is stored in the first cache lines.
> + *
>   * @basetime is used to store the base time for the system wide time getter
>   * VVAR page.
>   *
> 

-- 
Regards,
Vincenzo