Re: [PATCH v4] tty: serial: ma35d1: Add a NULL check for of_node
From: Dan Carpenter
Date: Mon Jul 01 2024 - 11:11:45 EST
On Tue, Jun 25, 2024 at 06:41:28AM +0000, Jacky Huang wrote:
> From: Jacky Huang <ychuang3@xxxxxxxxxxx>
>
> The pdev->dev.of_node can be NULL if the "serial" node is absent.
> Add a NULL check to return an error in such cases.
>
> Fixes: 930cbf92db01 ("tty: serial: Add Nuvoton ma35d1 serial driver support")
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Closes: https://lore.kernel.org/all/8df7ce45-fd58-4235-88f7-43fe7cd67e8f@moroto.mountain/
> Signed-off-by: Jacky Huang <ychuang3@xxxxxxxxxxx>
> ---
> V3 -> V4: Move the version info lines to the correct position.
> V2 -> V3: Added the "Reported-by:" line.
> V1 -> V2: Added the "Fixes" line.
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
regards,
dan carpenter