Re: [PATCH 4/5] x86/vgtod: Remove unused typedef gtod_long_t

From: Vincenzo Frascino
Date: Mon Jul 01 2024 - 11:20:29 EST




On 01/07/2024 15:47, Anna-Maria Behnsen wrote:
> The typedef gtod_long_t is not used anymore so remove it.
>
> The header file contains then only includes dependent on
> CONFIG_GENERIC_GETTIMEOFDAY to not break ARCH=um. Nevertheless, keep the
> header file only with those includes to prevent spreading ifdeffery all
> over the place.
>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Borislav Petkov <bp@xxxxxxxxx>
> Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> Cc: H. Peter Anvin <hpa@xxxxxxxxx>
> Cc: x86@xxxxxxxxxx
> Signed-off-by: Anna-Maria Behnsen <anna-maria@xxxxxxxxxxxxx>

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>

> ---
> arch/x86/include/asm/vgtod.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/x86/include/asm/vgtod.h b/arch/x86/include/asm/vgtod.h
> index 7aa38b2ad8a9..a0ce291abcae 100644
> --- a/arch/x86/include/asm/vgtod.h
> +++ b/arch/x86/include/asm/vgtod.h
> @@ -14,11 +14,6 @@
>
> #include <uapi/linux/time.h>
>
> -#ifdef BUILD_VDSO32_64
> -typedef u64 gtod_long_t;
> -#else
> -typedef unsigned long gtod_long_t;
> -#endif
> #endif /* CONFIG_GENERIC_GETTIMEOFDAY */
>
> #endif /* _ASM_X86_VGTOD_H */
>

--
Regards,
Vincenzo