Re: [PATCH v3 06/11] KVM: VMX: Expand FRED kvm entry with event data

[Jacob Pan]

On Fri, 28 Jun 2024 21:01:28 -0700, Xin Li <xin@xxxxxxxxx> wrote:

> On 6/28/2024 1:18 PM, Jacob Pan wrote:
> > From: Zeng Guang <guang.zeng@xxxxxxxxx>
> > 
> > For VM exits caused by events (NMI, #DB, and #PF) delivered by FRED, the
> > event data is saved in the exit-qualification field. (FRED spec.
> > 10.6.2)  
> 
> I don't like mentioning #DB/#PF here, they belong to the guest that was 
> running, and KVM handles them.
It is part of the spec.

> While NMIs belong to host, and the host NMI handler needs event data
> saved in VMCS in NMI induced VM exits.
> 
> Or you paint a full picture.
I will add your explanation that #DB/#PF belong to the guest so readers can
get a full picture of both usage and spec.
> 
> > Expand FRED KVM entry interface to include the event data obtained from
> > the exit qualification.
> > 
> > Signed-off-by: Zeng Guang <guang.zeng@xxxxxxxxx>
> > Signed-off-by: Jacob Pan <jacob.jun.pan@xxxxxxxxxxxxxxx>  
> 


Thanks,

Jacob