Re: [PATCH net-next v2 2/3] net: dsa: microchip: lan937x: disable in-band status support for RGMII interfaces

[Vladimir Oltean]

On Mon, Jul 01, 2024 at 10:53:42AM +0200, Oleksij Rempel wrote:
> From: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> 
> This driver do not support in-band mode and in case of CPU<->Switch
> link, this mode is not working any way. So, disable it otherwise ingress
> path of the switch MAC will stay disabled.
> 
> Note: lan9372 manual do not document 0xN301 BIT(2) for the RGMII mode
> and recommend[1] to disable in-band link status update for the RGMII RX
> path by clearing 0xN302 BIT(0). But, 0xN301 BIT(2) seems to work too, so
> keep it unified with other KSZ switches.
> 
> [1] https://microchip.my.site.com/s/article/LAN937X-The-required-configuration-for-the-external-MAC-port-to-operate-at-RGMII-to-RGMII-1Gbps-link-speed
> 
> Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> ---
> changes v2:
> - use ksz_set_xmii() instead of LAN937X specific code
> ---

Reviewed-by: Vladimir Oltean <olteanv@xxxxxxxxx>