Re: [PATCH net-next 4/6] net: phy: dp83869: Support 1000Base-X and 100Base-FX SFP modules

[Andrew Lunn]

> +	dev_info(&phydev->mdio.dev, "%s SFP compatible link mode: %s\n", __func__,
> +		 phy_modes(interface));

Maybe phydev_debug().

> +
> +	dp83869 = phydev->priv;
> +
> +	switch (interface) {
> +	case PHY_INTERFACE_MODE_100BASEX:
> +		dp83869->mode = DP83869_RGMII_100_BASE;
> +		phydev->port = PORT_FIBRE;
> +		break;
> +	case PHY_INTERFACE_MODE_1000BASEX:
> +		dp83869->mode = DP83869_RGMII_1000_BASE;
> +		phydev->port = PORT_FIBRE;
> +		break;
> +	default:
> +		dev_err(&phydev->mdio.dev,
> +			"incompatible PHY-to-SFP module link mode %s!\n",
> +			phy_modes(interface));

phydev_err()?


    Andrew

---
pw-bot: cr