Re: [PATCH] scsi: sd: Fix unsigned expression compared with zero
From: Bart Van Assche
Date: Mon Jul 01 2024 - 13:08:50 EST
On 7/1/24 2:06 AM, Jiapeng Chong wrote:
The return value from the call to scsi_execute_cmd() is int. However, the
return value is being assigned to an unsigned int variable 'the_result',
so making 'the_result' an int.
Please explain the full effect of this patch in the patch description. I
think this patch causes a potential read of uninitialized data (sshdr)
to be skipped if scsi_execute_cmd() returns a negative value. Do you
agree with this?
Thanks,
Bart.