Re: [PATCH v3 11/11] KVM: X86: Use common code for PV IPIs in linux guest

[Xin Li]

On 7/1/2024 9:38 AM, Jacob Pan wrote:
> On Sat, 29 Jun 2024 11:38:10 -0700, Xin Li <xin@xxxxxxxxx> wrote:
>
> > On 6/28/2024 1:18 PM, Jacob Pan wrote:
> > > Paravirtual apic hooks to enable PV IPIs for KVM if the "send IPI"
> >
> > s/Paravirtual apic/Paravirtualize APIC/
>
> Paravirtual APIC makes sense to me. This is also the same language used in
> previous commits.

"Paravirtual apic hooks to enable..."

It needs to start with a verb, I can't read it as adj.

> How about:
>
> "The paravirtual APIC hooks in KVM, some of which are used for sending PV
> IPIs, can reuse common code for ICR preparation. This shared code also
> encompasses NMI-source reporting when in effect."

LGTM.

> > > hypercall is available. Reuse common code for ICR preparation which
> > > covers NMI-source reporting if in effect.
> >
> > I see a lot of "NMI source". Should we use "NMI-source" in all places?
> Not really, here NMI-source is a compound modifier before noun "reporting".
>
> For other places, hyphen(-) is not needed if it is just a noun. e.g.
> "partial due to unknown NMI sources"
>
> I will go through the patchset to make sure they are consistent.

Right, make them consistent.