Re: [PATCH RFC 7/7] pci: pwrctl: Add power control driver for qps615

[Bjorn Helgaas]

On Wed, Jun 26, 2024 at 06:07:55PM +0530, Krishna chaitanya chundru wrote:
> QPS615 switch needs to configured after powering on and before
> PCIe link was up.

s/need to configured/needs to be configured/

> As the PCIe controller driver already enables the PCIe link training
> at the host side, stop the link training.

Add blank line between paragraphs or rewrap into a single paragraph.

> Otherwise the moment we turn on the switch it will participate in
> the link training and link may come before switch is configured through
> i2c.

s/link may come before/link may come up before/ ?

> The switch can be configured different ways like changing de-emphasis
> settings of the switch, disabling unused ports etc and these settings
> can vary from board to board, for that reason the sequence is taken
> from the firmware file which contains the address of the slave, to address
> and data to be written to the switch. The driver reads the firmware file
> and parses them to apply those configurations to the switch.

s/to address and data/the address and the data/ ?
s/and parses them/and parses it/ (I assume you parse the file?)