Re: [PATCH v23 14/19] x86/resctrl: Handle removing directories in Sub-NUMA Cluster (SNC) mode
From: Borislav Petkov
Date: Tue Jul 02 2024 - 04:54:15 EST
On Fri, Jun 28, 2024 at 02:56:14PM -0700, Tony Luck wrote:
> list_for_each_entry(prgrp, &rdt_all_groups, rdtgroup_list) {
> - sprintf(name, "mon_%s_%02d", r->name, dom_id);
> - kernfs_remove_by_name(prgrp->mon.mon_data_kn, name);
> + kn = kernfs_find_and_get(prgrp->mon.mon_data_kn, name);
> + if (!kn)
> + continue;
> + kernfs_put(kn);
> +
> + if (kn->dir.subdirs <= 1)
> + kernfs_remove(kn);
> + else
> + kernfs_remove_by_name(kn, subname);
This...
>
> - list_for_each_entry(crgrp, &prgrp->mon.crdtgrp_list, mon.crdtgrp_list)
> - kernfs_remove_by_name(crgrp->mon.mon_data_kn, name);
> + list_for_each_entry(crgrp, &prgrp->mon.crdtgrp_list, mon.crdtgrp_list) {
> + kn = kernfs_find_and_get(crgrp->mon.mon_data_kn, name);
> + if (!kn)
> + continue;
> + kernfs_put(kn);
> +
> + if (kn->dir.subdirs <= 1)
> + kernfs_remove(kn);
> + else
> + kernfs_remove_by_name(kn, subname);
> + }
... and this are almost identical hunks.
Why isn't there a helper which gets called here?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette