RE: [EXT] Re: [PATCH v10 1/2] wifi: mwifiex: add host mlme for client mode

[David Lin]

Hi Brian,

> From: Brian Norris <briannorris@xxxxxxxxxxxx>
> Sent: Tuesday, July 2, 2024 4:47 AM
> To: David Lin <yu-hao.lin@xxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> kvalo@xxxxxxxxxx; francesco@xxxxxxxxxx; Pete Hsieh
> <tsung-hsien.hsieh@xxxxxxx>; Francesco Dolcini
> <francesco.dolcini@xxxxxxxxxxx>
> Subject: Re: [EXT] Re: [PATCH v10 1/2] wifi: mwifiex: add host mlme for client
> mode
> 
> 
> Hi David,
> 
> On Sun, Jun 30, 2024 at 6:12 PM David Lin <yu-hao.lin@xxxxxxx> wrote:
> > > -----Original Message-----
> > > From: David Lin <yu-hao.lin@xxxxxxx>
> > > Sent: Friday, June 21, 2024 12:36 PM
> > >
> > > > From: Brian Norris <briannorris@xxxxxxxxxxxx>
> > > > Sent: Friday, June 21, 2024 1:53 AM
> > > >
> > > > On Sat, May 25, 2024 at 12:50:59AM +0000, David Lin wrote:
> > > > > That is the reason that I suggest that we put comments and TODO
> > > > > to the
> > > > code.
> > > >
> > > > OK, I suppose that works for me.
> 
> ^^^
> I don't have anything to add to this. This means "go ahead with the quoted
> suggestion."
> 
> If you factor in the latest comments (which, I think is only the above at the
> moment) then v11 likely will be good to merge from my perspective.
> 
> > > I suggest that we just put your comments and prepare patch v11.
> >
> > I think WPA3 is more robust and updated security method. Please help to let
> this patch be accepted.
> > Please let me know what else should be done to let this patch be ACKed
> > by you. Another is already ACKed by you with minor modification.
> 
> See above.
> 
> Brian

I want to confirm with you:
For patch v11:

[1/2]: Carry your "Acked-by" tag with following comment put to the code
used to hook probe_client().

"hostapd looks for NL80211_CMD_PROBE_CLIENT support; otherwise, it
requires monitor-mode support (which mwifiex doesn't support). Provide
fake probe_client support to work around this."

[2/2]: Carry your "Acked-by" tag with the modification of mwifiex_mgmt_stypes.

Thanks,
David