RE: [PATCH v13] pwm: opencores: Add PWM driver support

[William Qiu]

> -----Original Message-----
> From: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> Sent: 2024年7月2日 17:22
> To: William Qiu <william.qiu@xxxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
> linux-pwm@xxxxxxxxxxxxxxx
> Cc: Uwe Kleine-König <ukleinek@xxxxxxxxxx>; Hal Feng
> <hal.feng@xxxxxxxxxxxxxxxx>
> Subject: Re: [PATCH v13] pwm: opencores: Add PWM driver support
> 
> On Di, 2024-07-02 at 16:38 +0800, William Qiu wrote:
> > Add driver for OpenCores PWM Controller. And add compatibility code
> > which based on StarFive SoC.
> >
> > Co-developed-by: Hal Feng <hal.feng@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Hal Feng <hal.feng@xxxxxxxxxxxxxxxx>
> > Signed-off-by: William Qiu <william.qiu@xxxxxxxxxxxxxxxx>
> > ---
> >  MAINTAINERS              |   7 ++
> >  drivers/pwm/Kconfig      |  12 ++
> >  drivers/pwm/Makefile     |   1 +
> >  drivers/pwm/pwm-ocores.c | 239
> > +++++++++++++++++++++++++++++++++++++++
> >  4 files changed, 259 insertions(+)
> >  create mode 100644 drivers/pwm/pwm-ocores.c
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS index
> > 3c4fdf74a3f9..3b547ede2ce5 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -16824,6 +16824,13 @@ F:	Documentation/i2c/busses/i2c-ocores.rst
> >  F:	drivers/i2c/busses/i2c-ocores.c
> >  F:	include/linux/platform_data/i2c-ocores.h
> >
> > +OPENCORES PWM DRIVER
> > +M:	William Qiu <william.qiu@xxxxxxxxxxxxxxxx>
> > +M:	Hal Feng <hal.feng@xxxxxxxxxxxxxxxx>
> > +S:	Supported
> > +F:	Documentation/devicetree/bindings/pwm/opencores,pwm.yaml
> > +F:	drivers/pwm/pwm-ocores.c
> > +
> >  OPENRISC ARCHITECTURE
> >  M:	Jonas Bonn <jonas@xxxxxxxxxxxx>
> >  M:	Stefan Kristiansson <stefan.kristiansson@xxxxxxxxxxxxx>
> > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig index
> > 1dd7921194f5..42158bc1c8bc 100644
> > --- a/drivers/pwm/Kconfig
> > +++ b/drivers/pwm/Kconfig
> > @@ -440,6 +440,18 @@ config PWM_NTXEC
> >  	  controller found in certain e-book readers designed by the original
> >  	  design manufacturer Netronix.
> >
> > +config PWM_OCORES
> > +	tristate "OpenCores PTC PWM support"
> > +	depends on HAS_IOMEM && OF
> > +	depends on COMMON_CLK && RESET_CONTROLLER
> 
> The reset controller API has stubs in case RESET_CONTROLLER is disabled, so in
> general reset consumers don't need to depend on it.
> 
> regards
> Philipp

I see, I'll drop it.

Best Regards,
William